Skip to content

net: reduce CAddress usage to CService or CNetAddr

Placeholder Vasil Dimov requested to merge github/fork/vasild/reduce_CAddress into master

Using CAddress when only CService or CNetAddr is needed is excessive and confusing. Fix those occurrences to use the class they need:

  • CConnman::CalculateKeyedNetGroup() needs CNetAddr, not CAddress, thus change its argument.

  • Both callers of CConnman::CreateNodeFromAcceptedSocket() create a dummy CAddress from CService, so use CService instead.

  • GetBindAddress() only needs to return CService.

  • CNode::addrBind only needs to be CService.

Merge request reports