Skip to content

test, tracing: don't use problematic `bpf_usdt_readarg_p()`

Placeholder b10c requested to merge github/fork/0xB10C/2025-01-dont-use-bpf_usdt_readarg_p into master

Instead of using the undocumented bcc helper bpf_usdt_readarg_p(), use bpf_usdt_readarg() and bpf_probe_read_user()/bpf_probe_read_user_str() as documented in the bcc USDT reference guide.

Note that the bpf_probe_read_user() documentation says the following:

For safety, all user address space memory reads must pass through bpf_probe_read_user().

It's assumed that using bpf_usdt_readarg_p() caused a lifetime issue. With bpf_usdt_readarg() and bpf_probe_read_user(), this doesn't seem to be a problem anymore.

This allows to revert https://github.com/bitcoin/bitcoin/commit/faed5337435f025811caeb5f782ecbf9683a24b3 and closes #27380.

Merge request reports