Skip to content

Remove confusing and useless "unexpected version" warning

Placeholder github Source User requested to merge github/fork/maflcko/2010-valRemVerWarn into master

It is useless because it isn't displayed for most users:

  • It isn't displayed in normal operation (because the validation debug category is disabled by default)
  • It isn't displayed for users that sync up their nodes intermittently, e.g. once a day or once a week (because it is disabled for IBD)
  • It is only displayed in the debug log (as opposed to the versionbits warning, which is displayed more prominently)

It is confusing because it doesn't have a use case:

Despite the above, if a user did see the warning, it would most likely be a false positive (like it has been in the past). Even if it wasn't, there is nothing they can do about it. The only thing they could do is to check for updates and hope that a fixed version is available. But why would the user be so scrupulously precise in enabling the warning and reading the log, but then fail to regularly check update channels for updated software?

Merge request reports