Skip to content

build: Make config warnings fatal if -DWCONFIGURE_ERROR=ON

Placeholder David Gumberg requested to merge github/fork/davidgumberg/1-15-24-configure_warnings into master

Summarizing #31476, the CentOS CI task has been configuring a build with python 3.9 (the latest version in the Stream 9 BaseOS repository) which is below the minimum version of 3.10 which resulted in a warning being appended to the configure_warnings cmake variable. https://github.com/bitcoin/bitcoin/blob/712cab3a8f8ad76db959337ddc35cb4c34cac388/CMakeLists.txt#L546-L553

This warning has been emitted by every CI run on CentOS1 since the minimum version was bumped (#30527) and until the centos task was bumped to stream 10 in #31593 But this has not resulted in CI failure, even though utils and rpcauth tests have been skipped.

This branch adds a cmake build option WCONFIGURE_ERROR that if on makes the presence of configure_warnings a FATAL_ERROR it also makes an incompatible BDB version a configure_warning if -DWARN_INCOMPATIBLE_BDB=ON.

  1. e.g. https://cirrus-ci.com/task/5526283183980544?logs=ci#L895, https://cirrus-ci.com/task/6597682371756032?logs=ci#L894 ↩

Merge request reports