Skip to content

test: Move `script_assets_tests` into its own suite

Placeholder Hennadii Stepanov requested to merge github/fork/hebasto/241227-test-assets into master

This PR ensures that the script_assets_tests test case is explicitly reported as "Skipped" when it is not run, making it clearer when running the test suite with ctest:

$ env -u DIR_UNIT_TEST_DATA ctest --test-dir build -j 16 -R "^script_"
Internal ctest changing into directory: /home/hebasto/git/bitcoin/build
Test project /home/hebasto/git/bitcoin/build
    Start 87: script_tests
    Start 83: script_p2sh_tests
    Start 85: script_segwit_tests
    Start 86: script_standard_tests
    Start 84: script_parse_tests
1/5 Test #84: script_parse_tests ...............   Passed    0.11 sec
2/5 Test #86: script_standard_tests ............   Passed    0.11 sec
3/5 Test #85: script_segwit_tests ..............   Passed    0.12 sec
4/5 Test #83: script_p2sh_tests ................   Passed    0.12 sec
5/5 Test #87: script_tests .....................   Passed    0.36 sec

100% tests passed, 0 tests failed out of 5

Total Test time (real) =   0.37 sec
  • with this PR:
$ env -u DIR_UNIT_TEST_DATA ctest --test-dir build -j 16 -R "^script_"
Internal ctest changing into directory: /home/hebasto/git/bitcoin/build
Test project /home/hebasto/git/bitcoin/build
    Start 83: script_assets_tests
    Start 88: script_tests
    Start 84: script_p2sh_tests
    Start 86: script_segwit_tests
    Start 87: script_standard_tests
    Start 85: script_parse_tests
1/6 Test #85: script_parse_tests ...............   Passed    0.11 sec
2/6 Test #83: script_assets_tests ..............***Skipped   0.12 sec
3/6 Test #86: script_segwit_tests ..............   Passed    0.11 sec
4/6 Test #87: script_standard_tests ............   Passed    0.11 sec
5/6 Test #84: script_p2sh_tests ................   Passed    0.12 sec
6/6 Test #88: script_tests .....................   Passed    0.36 sec

100% tests passed, 0 tests failed out of 6

Total Test time (real) =   0.37 sec

The following tests did not run:
	 83 - script_assets_tests (Skipped)
$ env DIR_UNIT_TEST_DATA=/home/hebasto/git/bitcoin/qa-assets/unit_test_data ctest --test-dir build -j 16 -R "^script_"
Internal ctest changing into directory: /home/hebasto/git/bitcoin/build
Test project /home/hebasto/git/bitcoin/build
    Start 83: script_assets_tests
    Start 88: script_tests
    Start 84: script_p2sh_tests
    Start 86: script_segwit_tests
    Start 87: script_standard_tests
    Start 85: script_parse_tests
1/6 Test #85: script_parse_tests ...............   Passed    0.11 sec
2/6 Test #87: script_standard_tests ............   Passed    0.11 sec
3/6 Test #86: script_segwit_tests ..............   Passed    0.11 sec
4/6 Test #84: script_p2sh_tests ................   Passed    0.12 sec
5/6 Test #88: script_tests .....................   Passed    0.35 sec
6/6 Test #83: script_assets_tests ..............   Passed    1.58 sec

100% tests passed, 0 tests failed out of 6

Total Test time (real) =   1.58 sec

Merge request reports