Skip to content

netinfo: add peer services column and outbound-only option

Placeholder Jon Atack requested to merge github/fork/jonatack/2023-05-add-peer-services-to-netinfo into master

Been using this since May 2023.

  • add a peer services column (considered displaying the p2p_v2 flag as "p" or "2"; proposing "2" here for continuity with the "v" column, but "p" is fine for me as well)
  • clarify in the help that "relaytxes" and "addr_relay_enabled" are from getpeerinfo
  • hoist (and rename) the max level constant to use in top-level help, to avoid overlooking to update the top-level help if the value of the constant changes (as caught by Larry Ruane in review below)
  • add an optional "outonly" (or "o") argument for an outbound-only peer list, as suggested by Vasil Dimov in his review below. Several people have requested this, to keep the output within screen limits when running netinfo as a live dashboard (i.e. with watch) on a node with many peers. While doing this, also permit passing "h" for the help in addition to "help".

Merge request reports