Skip to content

refactor: performance-for-range-copy in psbt.h

Placeholder github Source User requested to merge github/fork/maflcko/2406-performance-for-range-copy into master

A copy of the partial signatures is not required before serializing them.

For reference, this was found by switching the codebase to std::span (not sure why it wasn't found with Span though):

./psbt.h:240:23: error: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy,-warnings-as-errors]
  240 |             for (auto sig_pair : partial_sigs) {
      |                       ^
      |                  const  &

Merge request reports