Skip to content

Make bitcoin include files modular / Qt4 compat

Placeholder github Source User requested to merge github/fork/laanwj/master into master

To be able to make an external GUI, I am working on modularizing bitcoin into a library. This push request is basic code plumbing, 100% no functional or build system changes.

  • Put guard statements around header files.
  • Removed macro foreach: conflicts with Qt4 keyword foreach, replaced with BOOST_FOREACH.
  • Prefix C++ stdlib structures and functions with std:: in headers; "using namespace" in header files is generally frowned upon because it 'infects' other files included after it. These are moved to the implementation files.
  • Modularity: base48.h and most other header files can now be included without the other shebang (useful for linking external GUI to bitcoin core, part of GUI separation). The include files that need each other, now include each other.

Merge request reports